KEMBAR78
PEP 484: Clarify that submodules in a package are exported by JelleZijlstra · Pull Request #309 · python/peps · GitHub
Skip to content

PEP 484: Clarify that submodules in a package are exported #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2017
Merged

PEP 484: Clarify that submodules in a package are exported #309

merged 2 commits into from
Jul 17, 2017

Conversation

@JelleZijlstra
Copy link
Member

ilevkivskyi
ilevkivskyi approved these changes Jul 15, 2017
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I would optionally add few examples below to illustrate what is imported and what is not. Even though this might seem trivial, it is easier for some people to grasp the idea from examples rather than from a specification.

@gvanrossum gvanrossum merged commit 7221386 into python:master Jul 17, 2017
@gvanrossum
Copy link
Member

Great! I couldn't have done it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra @gvanrossum @ilevkivskyi @the-knights-who-say-ni