Remove CPU and GPU support for approx_rowwise_adagrad[|with_counter] (#1770) #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytorch#1770) Summary: Pull Request resolved: pytorch#1770 This diff is a part of FBGEMM TBE optimizer deprecation plan (see pytorch#1727) Changes include: - Setting `has_cpu_support` and `has_gpu_support` of `approx_rowwise_adagrad` and `approx_rowwise_adagrad_with_counter` to `False` in the code gen script - Updating `codegen/TARGETS` and `CMakeLists.txt` See D45835048 for how the changes affect the code generation Differential Revision: D45844782 fbshipit-source-id: 6e6e87d6d9b4dd58531933e95fe55efbb0c12baa
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D45844782 |
|
This pull request has been merged in d207545. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is a part of FBGEMM TBE optimizer deprecation plan (see
#1727)
Changes include:
has_cpu_supportandhas_gpu_supportofapprox_rowwise_adagradandapprox_rowwise_adagrad_with_counterto
Falsein the code gen scriptcodegen/TARGETSandCMakeLists.txtSee D45835048 for how the changes affect the code generation
Differential Revision: D45844782