KEMBAR78
GitHub · Where software is built
Skip to content

Remove lazy behavior from MelScale #1569

@mthrok

Description

@mthrok

Address #1510

In 0.9.0 we are deprecating the lazy behavior of MelScale because it can make an invalid TorchScript object and it does not align with the design of torchaudio. Now in master branch, we can remove the implementation.

See CONTRIBUTING.md for setting up the development environment.

Steps

  1. Replace n_stft: Optional[int] = None with n_stft: int = 201.
  2. Remove the branches for n_stft = None
  3. Remove __prepare_script__ method
  4. Remove the case numel() == 0
  5. Remove test

Tests

Run test cd test && pytest torchaudio_unittest.transforms -vk MelScale and make changes to failures.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions