KEMBAR78
Remove `F.complex_norm` and `T.ComplexNorm` · Issue #1884 · pytorch/audio · GitHub
Skip to content

Remove F.complex_norm and T.ComplexNorm #1884

New issue
New issue
Closed
Closed
Remove F.complex_norm and T.ComplexNorm#1884
Labels
contributions welcomegood first issuehelp wanted
Milestone
v0.11
@mthrok

Description

@mthrok
mthrok
opened on Oct 15, 2021

As planned in #1337, F.complex_norm and T.ComplexNorm are now deprecated, and we can remove them.

Steps

  1. Remove the implementation

audio/torchaudio/functional/functional.py

Line 719 in 25a8adf

def complex_norm(

audio/torchaudio/transforms.py

Line 884 in bf580c7

class ComplexNorm(torch.nn.Module):

  1. Remove test

audio/test/torchaudio_unittest/functional/functional_impl.py

Lines 322 to 330 in 25a8adf

@parameterized.expand(
list(itertools.product([(1, 2, 1025, 400, 2), (1025, 400, 2)], [1, 2, 0.7]))
)
def test_complex_norm(self, shape, power):
torch.random.manual_seed(42)
complex_tensor = torch.randn(*shape, dtype=self.dtype, device=self.device)
expected_norm_tensor = complex_tensor.pow(2).sum(-1).pow(power / 2)
norm_tensor = F.complex_norm(complex_tensor, power)
self.assertEqual(norm_tensor, expected_norm_tensor, atol=1e-5, rtol=1e-5)

audio/test/torchaudio_unittest/transforms/torchscript_consistency_impl.py

Line 89 in 25a8adf

def test_ComplexNorm(self):

  1. Make sure the test passes.

  2. Update docs

https://github.com/pytorch/audio/blob/25a8adf6d642bc27b156a452bc80f20741382642/docs/source/functional.rst

https://github.com/pytorch/audio/blob/25a8adf6d642bc27b156a452bc80f20741382642/docs/source/transforms.rst

Note

For setting up the development environment, please refer to CONTRIBUTING.md and torchaudio_unittest

Metadata

Metadata

Assignees

No one assigned

    Labels

    contributions welcomegood first issuehelp wanted

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions