[BC-Breaking] Drop pseudo complex support from spectrogram #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
mthrok
force-pushed
the
remove-pseudo-complex-support-spectrogram
branch
from
6e80017 to
3fdd4cb
Compare
mthrok
requested review from
carolineechen,
hwangjeff and
nateanl
and removed request for
carolineechen and
nateanl
nateanl
approved these changes
Nov 3, 2021
| :attr:`center` is ``True``. Default: ``"reflect"`` | ||
| onesided (bool, optional): controls whether to return half of results to | ||
| avoid redundancy. Default: ``True`` | ||
| return_complex (bool, optional): |
There was a problem hiding this comment.
Suggested change
| return_complex (bool, optional): | |
| return_complex (bool or None, optional): |
There was a problem hiding this comment.
Here, None is is not a valid input and only used to detect if user pass something, so in docstring, we will keep it as bool.
| :attr:`center` is ``True``. (Default: ``"reflect"``) | ||
| onesided (bool, optional): controls whether to return half of results to | ||
| avoid redundancy (Default: ``True``) | ||
| return_complex (bool, optional): |
There was a problem hiding this comment.
Suggested change
| return_complex (bool, optional): | |
| return_complex (bool or None, optional): |
carolineechen
approved these changes
Nov 3, 2021
Co-authored-by: nateanl <nizhaoheng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the plan #1337, this PR drops the support for pseudo complex type from
F.spectrogramandT.Spectrogram. It also deprecates the use ofreturn_complexargument.