Enable mypy lintrunner, Part 2 (codegen/*, docs/*) #7493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7493
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 594556c with merge base c86b39d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mergennachin
force-pushed
the
lints_part_2
branch
from
be9fc3c to
2a7f7a7
Compare
Summary: Enabling mypy for codegen/* and docs/* Test Plan: Lintrunner CI Internal CI
mergennachin
force-pushed
the
lints_part_2
branch
from
2a7f7a7 to
594556c
Compare
This was referenced Jan 3, 2025
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Jan 3, 2025
tarun292
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enabling mypy for codegen/* and docs/*
For docs, the main problem in export-to-executorch-tutorial.py was redefinition types. Removing the typehints, except the first one.
Test plan
Lintrunner
CI
Internal CI
Summary
Fixes #7441