Fix ignoring Tensor properties in torch.overrides (#60050)

ezyang · facebook-github-bot · commit 1f50dc6e46e5 · 2021-06-21T14:49:51.000-07:00
Summary: Pull Request resolved: #60050 It doesn't work to put torch.Tensor.prop.__get__ in the ignored list. Now it does. (Not exercised here, see next diff in stack). Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D29171464 Pulled By: ezyang fbshipit-source-id: e7354668b481f9275f2eb5bb3a6228d1815fecea
diff --git a/torch/overrides.py b/torch/overrides.py
@@ -1381,8 +1381,14 @@ def get_overridable_functions() -> Dict[Any, List[Callable]]:
                 continue
 
             if not callable(func) and hasattr(func, "__get__"):
-                overridable_funcs[func].append(func.__get__)
-                continue
+                if func.__get__ in get_ignored_functions():
+                    msg = ("{}.{} is in the tuple returned by torch._overrides.get_ignored_functions "
+                           "but still has an explicit override")
+                    assert func.__get__ not in get_testing_overrides(), msg.format(namespace, func.__name__)
+                    continue
+                else:
+                    overridable_funcs[func].append(func.__get__)
+                    continue
 
             if not callable(func):
                 continue
