[inductor] process compile_only case in all build options class. (#129975)

xuhancn · pytorchmergebot · commit 89795da5e304 · 2024-08-13T16:45:27.000Z
Optimize `compile_only` logical. Origin code only apply for `CppTorchCudaOptions`, this PR make it apply for all build option classes. Changes: 1. Remove `libraries_dirs` and `libraries` settings, when `compile_only`. 2. Remove compile_only from CppTorchCudaOptions. 3. Make the `compile_only` apply for all classes. Pull Request resolved: #129975 Approved by: https://github.com/henrylhtsang
diff --git a/torch/_inductor/cpp_builder.py b/torch/_inductor/cpp_builder.py
@@ -330,6 +330,11 @@ def __init__(
         self._use_absolute_path: bool = use_absolute_path
         self._compile_only: bool = compile_only
 
+    def _process_compile_only_options(self) -> None:
+        if self._compile_only:
+            self._libraries_dirs = []
+            self._libraries = []
+
     def _remove_duplicate_options(self) -> None:
         self._definations = _remove_duplication_in_list(self._definations)
         self._include_dirs = _remove_duplication_in_list(self._include_dirs)
@@ -339,6 +344,10 @@ def _remove_duplicate_options(self) -> None:
         self._libraries = _remove_duplication_in_list(self._libraries)
         self._passthough_args = _remove_duplication_in_list(self._passthough_args)
 
+    def _finalize_options(self) -> None:
+        self._process_compile_only_options
+        self._remove_duplicate_options
+
     def get_compiler(self) -> str:
         return self._compiler
 
@@ -557,7 +566,7 @@ def __init__(
         _append_list(self._libraries_dirs, libraries_dirs)
         _append_list(self._libraries, libraries)
         _append_list(self._passthough_args, passthough_args)
-        self._remove_duplicate_options()
+        self._finalize_options()
 
 
 def _get_glibcxx_abi_build_flags() -> List[str]:
@@ -980,18 +989,14 @@ def __init__(
             use_mmap_weights=use_mmap_weights,
         )
 
-        if compile_only:
-            torch_libraries_dirs = []
-            torch_libraries = []
-
         _append_list(self._definations, torch_definations)
         _append_list(self._include_dirs, torch_include_dirs)
         _append_list(self._cflags, torch_cflags)
         _append_list(self._ldflags, torch_ldflags)
         _append_list(self._libraries_dirs, torch_libraries_dirs)
         _append_list(self._libraries, torch_libraries)
         _append_list(self._passthough_args, torch_passthough_args)
-        self._remove_duplicate_options()
+        self._finalize_options()
 
 
 def _set_gpu_runtime_env() -> None:
@@ -1144,19 +1149,14 @@ def __init__(
         ) = get_cpp_torch_cuda_options(
             cuda=cuda, aot_mode=aot_mode, compile_only=compile_only
         )
-
-        if compile_only:
-            cuda_libraries_dirs = []
-            cuda_libraries = []
-
         _append_list(self._definations, cuda_definations)
         _append_list(self._include_dirs, cuda_include_dirs)
         _append_list(self._cflags, cuda_cflags)
         _append_list(self._ldflags, cuda_ldflags)
         _append_list(self._libraries_dirs, cuda_libraries_dirs)
         _append_list(self._libraries, cuda_libraries)
         _append_list(self._passthough_args, cuda_passthough_args)
-        self._remove_duplicate_options()
+        self._finalize_options()
 
 
 def get_name_and_dir_from_output_file_path(
