Make breakpad depdendencies private (#61183)

malfet · facebook-github-bot · commit 95cada88105a · 2021-07-06T10:02:34.000-07:00
Summary: Otherwise, it will results in the following errors for people developing extensions ``` CMake Error in frontends/pytorch/csrc/CMakeLists.txt: Imported target "torch" includes non-existent path "/usr/local/include/breakpad" ``` Fixes different issue reported in #60485 Pull Request resolved: #61183 Reviewed By: driazati Differential Revision: D29538332 Pulled By: malfet fbshipit-source-id: e83cfd0b335e9b0b1ba5715789b09765db671346
diff --git a/caffe2/CMakeLists.txt b/caffe2/CMakeLists.txt
@@ -999,9 +999,9 @@ if(LINUX)
   find_path(BREAKPAD_INCLUDE_DIR breakpad)
   if(BREAKPAD_LIB AND BREAKPAD_INCLUDE_DIR)
     message(STATUS "found breakpad library")
-    target_link_libraries(torch_cpu PUBLIC ${BREAKPAD_LIB})
+    target_link_libraries(torch_cpu PRIVATE ${BREAKPAD_LIB})
     target_compile_definitions(torch_cpu PRIVATE ADD_BREAKPAD_SIGNAL_HANDLER)
-    target_include_directories(torch_cpu PUBLIC ${BREAKPAD_INCLUDE_DIR}/breakpad)
+    target_include_directories(torch_cpu PRIVATE ${BREAKPAD_INCLUDE_DIR}/breakpad)
   else()
     message(STATUS "breakpad library not found")
   endif()
