Update on "Deprecate torch.cross default behaviour"

lezcano · lezcano · commit ad88b7049204 · 2023-09-14T16:18:44.000Z
Long overdue this one. We may be able to change it in a few years :hopeful:. **BC-breaking note** This PR deprecates `torch.cross`'s default dim in favor of `torch.linalg.cross`. A upgrade guide is added to the documentation for `torch.cross`. Note this PR DOES NOT remove `torch.cross`. Fixes #108664 cc jianyuh nikitaved pearu mruberry walterddr IvanYashchuk xwang233 Lezcano [ghstack-poisoned]
diff --git a/aten/src/ATen/native/Cross.cpp b/aten/src/ATen/native/Cross.cpp
@@ -62,7 +62,7 @@ Tensor cross(const Tensor & input, const Tensor & other, const c10::optional<int
   if (!dimension) {
     TORCH_WARN_ONCE(
       "Using torch.cross without specifying the dim arg is deprecated.\n",
-      "Please either pass the dim explicitly or simply use linalg.cross.\n",
+      "Please either pass the dim explicitly or simply use torch.linalg.cross.\n",
       "The default value of dim will change to agree with that of linalg.cross in a future release."
     );
   }
