Update on "[inductor] Enable floor_div indexing to work under ABI-compat mode"

int3 · int3 · commit ade102946f27 · 2023-11-10T15:48:59.000-08:00
Previously, floor_div operations were defined in
ATen/native/BinaryOps.h. Since this header was not included under
ABI-compat mode, trying to use those indexing operations would result in
compilation errors.

Technically, it is safe to use aten::native::floor_div_* functions in
ABI-compat mode as they are header-only; we could simply include
BinaryOps.h. However, there are other declarations in BinaryOps.h that
are not binary-compatible, so this is not ideal. Thus, I have moved those
functions into a separate file, and put them under c10/util, since they
don't really have tensor-specific logic.

c10 functions are not all header-only, so this still isn't ideal, but
this still seems like an improvement. Moreover, cpp_prefix.h -- used
when compiling cpp kernels -- already includes c10 header files, so
ABI-compatibility already depends on maintaining some c10 functions as
header-only.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
diff --git a/test/inductor/test_indexing.py b/test/inductor/test_indexing.py
@@ -248,7 +248,7 @@ def test_print_floor_div(self):
                 self.assertEqual(pexpr(expr), "(s1 // (-1))")
                 self.assertEqual(
                     cexpr(expr),
-                    "at::native::div_floor_floating(static_cast<double>(s1), static_cast<double>((-1L)))",
+                    "c10::div_floor_floating(static_cast<double>(s1), static_cast<double>((-1L)))",
                 )
 
     def test_print_Min_Max(self):
