Update on "[MPS] Fix bfloat to complex casts"

malfet · malfet · commit ebf87c7b4cd1 · 2024-10-01T06:37:51.000-07:00
For Metal cast ops to comple, one need to explicitly cast to/from `bfloat` unlike for other dtypes Tested in #136987 [ghstack-poisoned]
diff --git a/aten/src/ATen/native/mps/operations/View.mm b/aten/src/ATen/native/mps/operations/View.mm
@@ -735,7 +735,7 @@ static IntArrayRef updateTensorBaseShape(const Tensor& self) {
   if (dstComplex) {
     // TODO: Document why explicit cast is needed only for bfloat types
     if (dtypeSrc == "bfloat") {
-        return dtypeDst + "(float(x), 0.0)";
+      return dtypeDst + "(float(x), 0.0)";
     }
     return dtypeDst + (srcComplex ? needsConj ? "(x.x, -x.y)" : "(x.x, x.y)" : "(x,  0.0)");
   }
@@ -750,7 +750,7 @@ static IntArrayRef updateTensorBaseShape(const Tensor& self) {
   if (dtypeDst == "bfloat") {
     return "bfloat(x)";
   }
-  return dtypeSrc == "bfloat" ? dtypeDst + "(x)" :  "(x)";
+  return dtypeSrc == "bfloat" ? dtypeDst + "(x)" : "(x)";
 }
 
 static MetalShaderLibrary scatterLib(SCATTER_OPS_TEMPLATE, 3);
