-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Closed
Labels
module: abilibtorch C++ ABI related problemslibtorch C++ ABI related problemsmodule: binariesAnything related to official binaries that we release to usersAnything related to official binaries that we release to usersmodule: cppRelated to C++ APIRelated to C++ APItriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
The function signature THPVariable_Wrap changes between versions with the same major.minor.alpha. Specifically
- 2.6.0a0+ecf3bae40a -- TORCH_PYTHON_API PyObject* THPVariable_Wrap(at::TensorBase var);
- 2.6.0a0+df5bbc09d1 -- TORCH_PYTHON_API PyObject* THPVariable_Wrap(const at::TensorBase& var);
This causes breaking changes in any application that is linked against this API, because the name mangling for the method will change:
- 2.6.0a0+ecf3bae40a -- _Z16THPVariable_WrapN2at10TensorBaseE
- 2.6.0a0+df5bbc09d1 -- _Z16THPVariable_WrapRKN2at10TensorBaseE
If externs were used, this might not be an issue. However, that is not used for this API.
Impact is that any application compiled against 2.6.0a0 may not work with other versions at 2.6.0a0.
Versions
2.6.0a0+ecf3bae40a
2.6.0a0+df5bbc09d1
Metadata
Metadata
Assignees
Labels
module: abilibtorch C++ ABI related problemslibtorch C++ ABI related problemsmodule: binariesAnything related to official binaries that we release to usersAnything related to official binaries that we release to usersmodule: cppRelated to C++ APIRelated to C++ APItriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module