-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Open
Labels
high prioritymodule: buildBuild system issuesBuild system issuesmodule: cpuCPU specific problem (e.g., perf, algorithm)CPU specific problem (e.g., perf, algorithm)module: crashProblem manifests as a hard crash, as opposed to a RuntimeErrorProblem manifests as a hard crash, as opposed to a RuntimeErrormodule: windowsWindows support for PyTorchWindows support for PyTorchtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
Background
This issue is re-submit of #145042, because of we taked about this issue and we think the original issue will make us confuse it is a XPU related issue. But acturally it is a CPU only issue.
Reproduce steps:
- It is easy step to reproduce it, just switch Windows CPU build to VS2022. Reference to [don't merge] use vs2022 build windows cpu wheel. #143791
- Add
ciflow/binariestag to trigger nightly binary build. - Download
wheel-py3_10-cpuwheel fromArtifactspage https://github.com/pytorch/pytorch/actions/runs/12972478091?pr=143791 - Install the wheel to the CPU, which max ISA level is
AVX2. - Run the reproduce code via
pytest:
# cpu_vs2022_inst_issue.py
import torch
class TestClass:
def test_grid_sampler_2d(self):
torch.manual_seed(0)
b = torch.rand(2, 13, 10, 2, dtype=torch.float64)
a = torch.rand(2, 3, 5, 20, dtype=torch.float64)
torch.grid_sampler_2d(a, b, interpolation_mode=0, padding_mode=0, align_corners=False)command line:
pytest -v cpu_vs2022_inst_issue.pyRoot cause
I debugged it via WinDBG, the reason is VS2022 genarated AVX512 instruction, and it is run on the client CPU, which max ISA level is AVX2.
Additional information
- This issue is not impact on currenct PyTorch officical binaries, because of current PyTorch official binaries built by VS2019.
- The PyTorch CI can't test this issue, due to the CI runs on server CPU, which is support AVX512.
- I tried to reproduce it on my local VS2022 build environment, but it is can't reproduce. I think it only occurred issue on PyTorch official build environment.
- I just open this issue for track it, to avoid to upgrade VS2022 and occurred this issue, in the further.
- It is not impact on official PyTorch binary, so I will add
low prioritytag.
cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @malfet @seemethere @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10
Metadata
Metadata
Assignees
Labels
high prioritymodule: buildBuild system issuesBuild system issuesmodule: cpuCPU specific problem (e.g., perf, algorithm)CPU specific problem (e.g., perf, algorithm)module: crashProblem manifests as a hard crash, as opposed to a RuntimeErrorProblem manifests as a hard crash, as opposed to a RuntimeErrormodule: windowsWindows support for PyTorchWindows support for PyTorchtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module