-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Closed
Labels
module: onnxRelated to torch.onnxRelated to torch.onnxtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
Description
Setting fallback=True in torch.onnx.export complicates the error messages for users using the exporter with default settings, who are expecting the exporter to take the dynamo path. It will tall users to provide the f arg, for example, and flushes the dynamo error messages with torchscript errors if both paths fails etc.
Overall, it leads to a confusing experience and IMO should only be turned on at user request.
Metadata
Metadata
Assignees
Labels
module: onnxRelated to torch.onnxRelated to torch.onnxtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module