KEMBAR78
[complex] torch.polar accepts negative values for `abs` argument · Issue #52919 · pytorch/pytorch · GitHub
Skip to content

[complex] torch.polar accepts negative values for abs argument #52919

@kshitij12345

Description

@kshitij12345
>>> abs_t = torch.tensor([-1., 2, -3])
>>> angle_t = torch.randn(3)
>>> torch.polar(abs_t, angle_t)
tensor([-0.7947-0.6070j,  1.2734-1.5422j, -2.6964+1.3151j])

It should error out if abs<0.

We should add checks in the following kernel

cpu_kernel(iter, [=](scalar_t a, scalar_t b) -> c10::complex<scalar_t> {
return c10::complex<scalar_t>(a * std::cos(b), a * std::sin(b));
});

iter, [] GPU_LAMBDA(scalar_t a, scalar_t b) -> c10::complex<scalar_t> {
return c10::complex<scalar_t>(a * std::cos(b), a * std::sin(b));

cc @ezyang @anjali411 @dylanbespalko @mruberry @brianjo

Metadata

Metadata

Assignees

No one assigned

    Labels

    module: complexRelated to complex number support in PyTorchmodule: docsRelated to our documentation, both in docs/ and docblockstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions