KEMBAR78
Add decomposition for `aten.take_along_dim` by guilhermeleobas · Pull Request #108185 · pytorch/pytorch · GitHub
Skip to content

Add decomposition for aten.take_along_dim #108185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add decomposition for aten.take_along_dim #108185

wants to merge 5 commits into from

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Aug 29, 2023 •
edited by pytorch-bot bot
Loading

@guilhermeleobas guilhermeleobas self-assigned this Aug 29, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108185

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0365253 with merge base 29f17e1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guilhermeleobas guilhermeleobas changed the title Add decomposition for torch.take_along_dim Add decomposition for aten.take_along_dim Aug 29, 2023
@guilhermeleobas guilhermeleobas marked this pull request as ready for review August 30, 2023 20:55
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 30, 2023
lezcano
lezcano approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing. Otherwise,iIf the test pass this should be good to go.

torch/_refs/__init__.py Outdated
)

if dim is None:
return aten.gather(a.view(-1), 0, indices.view(-1))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's in refs, this should be torch.gather.

@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 1, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm5.6-py3.8 / test (default, 3, 3, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/take_along_dim branch from e08311c to 39e6443 Compare September 1, 2023 20:07
@github-actions github-actions bot added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Sep 1, 2023
@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/take_along_dim branch from 39e6443 to e08311c Compare September 1, 2023 20:16
@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/take_along_dim branch from e08311c to 0365253 Compare September 1, 2023 20:24
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@ngimel ngimel Awaiting requested review from ngimel

Assignees

@guilhermeleobas guilhermeleobas

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration open source release notes: inductor triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guilhermeleobas @pytorchmergebot @lezcano @colesbury @pytorchbot