KEMBAR78
[export] Copy gm before calling PassManager by digantdesai · Pull Request #108321 · pytorch/pytorch · GitHub
Skip to content

[export] Copy gm before calling PassManager #108321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[export] Copy gm before calling PassManager #108321

wants to merge 1 commit into from

Conversation

@digantdesai
Copy link
Contributor

Test Plan: CI

Reviewed By: angelayi, cccclai

Differential Revision: D48801487

@digantdesai @facebook-github-bot
[export] Copy gm before calling PassManager
912fdcf 
Test Plan: CI

Reviewed By: angelayi, cccclai

Differential Revision: D48801487

fbshipit-source-id: 391c490ee5acf278c2acff9ff6000162e340b7ab
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108321

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 912fdcf with merge base 11860d9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48801487

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@digantdesai digantdesai requested a review from angelayi August 31, 2023 02:58
mcr229
mcr229 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mcr229 mcr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 31, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@digantdesai
Copy link
Contributor Author

getting reverted - don't want to pick this in 2.1 cc @angelayi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimishpatel kimishpatel kimishpatel approved these changes

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

+1 more reviewer

@mcr229 mcr229 mcr229 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@digantdesai @facebook-github-bot @pytorchmergebot @kimishpatel @mcr229