KEMBAR78
Hide __getattr__ from type checkers by hauntsaninja · Pull Request #109683 · pytorch/pytorch · GitHub
Skip to content

Hide __getattr__ from type checkers #109683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Hide __getattr__ from type checkers #109683

wants to merge 9 commits into from

Conversation

@hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Sep 20, 2023 •
edited by pytorch-bot bot
Loading

Visibility of this causes type checkers to conservatively assume that all attributes are defined on torch module.

cc @ezyang @malfet @rgommers @xuzhao9 @gramster

@hauntsaninja
Hide __getattr__ from type checkers
5d91e4a 
Visibility of this causes type checkers to conservatively assume that
all attributes are defined on torch module.
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109683

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5df8d4f with merge base 6e3a747 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@hauntsaninja
Copy link
Contributor Author

@pytorchbot label "module: typing"

@hauntsaninja
Copy link
Contributor Author

@pytorchbot label "release notes: python_frontend"

@pytorch-bot pytorch-bot bot added module: typing Related to mypy type annotations release notes: python_frontend python frontend release notes category labels Sep 20, 2023
malfet
malfet reviewed Sep 20, 2023
View reviewed changes
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Comment with id 1728147764 not found

Details for Dev Infra team Raised by workflow job

@malfet malfet added the topic: improvements topic category label Sep 20, 2023
@malfet
Copy link
Contributor

malfet commented Sep 20, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@hauntsaninja
Copy link
Contributor Author

Rebased! I fixed some of the type errors that got introduced and hidden after my previous merge base, but just type ignored others. It would be nice to merge before too many further regressions are committed to main.

@ezyang
Copy link
Contributor

ezyang commented Sep 21, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@ezyang ezyang ezyang approved these changes

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: typing Related to mypy type annotations open source release notes: python_frontend python frontend release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hauntsaninja @pytorchmergebot @malfet @ezyang @ngimel @pytorchbot