-
Notifications
You must be signed in to change notification settings - Fork 25.7k
removing the functionality of nvfuser python APIs #110124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110124
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5219d14 with merge base 81da6db ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Maybe put somewhere a note in the docs on why it was deprecated? It's useful because a lot of education materials are published and are not going to be changed, including about nvfuser. So it's good to have some trace of its prior existence in the docs, even if just saying that it was available in these versions and was deprecated for these reasons. |
|
failing test doesn't seem to be relevant. |
We do have release note for that. I'm open-minded if there's a better place to put a note for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can you leave a few of the comments in OVERVIEW.md?
| | NNC on CPU | `torch._C._jit_override_can_fuse_on_cpu()` | | ||
| | NNC on GPU | `torch._C._jit_override_can_fuse_on_gpu()` | | ||
| | NNC context manager | `with torch.jit.fuser("fuser1"):` | | ||
| | NVFuser enable/disable | `torch._C._jit_set_nvfuser_enabled()` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave these comments, maybe with a note about deprecation?
| | NNC enable/disable | `torch::jit::setTensorExprFuserEnabled(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/passes/tensorexpr_fuser.h#L22) | | ||
| | NNC on CPU | `torch::jit::overrideCanFuseOnCPU(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/codegen/fuser/interface.h#L28-L29) | | ||
| | NNC on GPU | `torch::jit::overrideCanFuseOnGPU(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/codegen/fuser/interface.h#L28-L29) | | ||
| | NVFuser enable/disable | `torch::jit::fuser::cuda::setEnabled(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/codegen/cuda/interface.h#L56) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and these comments too
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Removing the functionalities from nvfuser python APIs.
Since the use of nvfuser has been deprecated before the last release cut. We are removing torch script support.
I'll have the next PR to actually remove the code base.