KEMBAR78
removing the functionality of nvfuser python APIs by jjsjann123 · Pull Request #110124 · pytorch/pytorch · GitHub
Skip to content

Conversation

@jjsjann123
Copy link
Collaborator

Removing the functionalities from nvfuser python APIs.

Since the use of nvfuser has been deprecated before the last release cut. We are removing torch script support.

I'll have the next PR to actually remove the code base.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Sep 26, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110124

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5219d14 with merge base 81da6db (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jjsjann123 jjsjann123 added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 26, 2023
@vadimkantorov
Copy link
Contributor

vadimkantorov commented Sep 27, 2023

Maybe put somewhere a note in the docs on why it was deprecated? It's useful because a lot of education materials are published and are not going to be changed, including about nvfuser. So it's good to have some trace of its prior existence in the docs, even if just saying that it was available in these versions and was deprecated for these reasons.

@jjsjann123
Copy link
Collaborator Author

failing test doesn't seem to be relevant.

  File "inductor/test_torchinductor_codegen_dynamic_shapes.py", line 332 in <module>
FINISHED PRINTING LOG FILE of inductor/test_torchinductor_codegen_dynamic_shapes 1/4 (/var/lib/jenkins/pytorch/test/test-reports/inductor-test_torchinductor_codegen_dynamic_shapes_cy7zi9za.log)

Running inductor/test_torchinductor_dynamic_shapes 3/4 ... [2023-09-27 02:36:22.180530]
inductor/test_torchinductor_codegen_dynamic_shapes 1/4 failed! Received signal: SIGIOT
Executing ['/opt/conda/envs/py_3.8/bin/python', '-bb', 'inductor/test_torchinductor_dynamic_shapes.py', '--shard-id=2', '--num-shards=4', '-v', '-vv', '-rfEX', '-p', 'no:xdist', '--use-pytest', '--sc=inductor/test_torchinductor_dynamic_shapes_2', '-x', '--reruns=2', '--import-slow-tests', '--import-disabled-tests'] ... [2023-09-27 02:36:22.181133]
/var/lib/jenkins/pytorch/tools/stats/upload_metrics.py:163: UserWarning: Error uploading metric td_experiment_1 to DynamoDB: Unable to locate credentials
  warn(f"Error uploading metric {metric_name} to DynamoDB: {e}")

@jjsjann123
Copy link
Collaborator Author

Maybe put somewhere a note in the docs on why it was deprecated? It's useful because a lot of education materials are published and are not going to be changed, including about nvfuser. So it's good to have some trace of its prior existence in the docs, even if just saying that it was available in these versions and was deprecated for these reasons.

We do have release note for that.
2.1 has nvfuser in deprecation for TorchScript. Removing it is the natural follow-up step for that.

I'm open-minded if there's a better place to put a note for that.

@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 27, 2023
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you leave a few of the comments in OVERVIEW.md?

| NNC on CPU | `torch._C._jit_override_can_fuse_on_cpu()` |
| NNC on GPU | `torch._C._jit_override_can_fuse_on_gpu()` |
| NNC context manager | `with torch.jit.fuser("fuser1"):` |
| NVFuser enable/disable | `torch._C._jit_set_nvfuser_enabled()` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave these comments, maybe with a note about deprecation?

| NNC enable/disable | `torch::jit::setTensorExprFuserEnabled(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/passes/tensorexpr_fuser.h#L22) |
| NNC on CPU | `torch::jit::overrideCanFuseOnCPU(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/codegen/fuser/interface.h#L28-L29) |
| NNC on GPU | `torch::jit::overrideCanFuseOnGPU(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/codegen/fuser/interface.h#L28-L29) |
| NVFuser enable/disable | `torch::jit::fuser::cuda::setEnabled(bool);` | [here](https://github.com/pytorch/pytorch/blob/1a7e560adecb0192f69f4d05b990800b60dc380b/torch/csrc/jit/codegen/cuda/interface.h#L56) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and these comments too

@jjsjann123
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jjsjann123 jjsjann123 deleted the nvfuser_python_api_removal branch September 29, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants