[Inductor] support channel last for xpu conv in inductor layout opt path #111018

guangyey · 2023-10-11T02:44:15Z

Motivation

support xpu channel last for inductor layout optimization path.
Currently, _conv_determine_backend_memory_format always returns torch.contiguous_format for XPU conv.

Solution

Add xpu channel last detection stragey in determine_backend_memory_format

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

pytorch-bot · 2023-10-11T02:44:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111018

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 074222b with merge base 5614023 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guangyey · 2023-10-11T02:46:03Z

@pytorchbot label "topic: not user facing"

guangyey · 2023-10-11T02:47:11Z

@jansel please help review.

guangyey · 2023-10-11T02:47:58Z

cc @jgong5 @EikanWang @arthuryuan1987

guangyey · 2023-10-11T23:05:28Z

@pytorchbot merge

pytorchmergebot · 2023-10-11T23:07:28Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

guangyey · 2023-10-12T01:39:58Z

@pytorchbot rebase

guangyey · 2023-10-12T01:40:42Z

@pytorchbot merge

pytorchmergebot · 2023-10-12T01:41:01Z

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

pytorchmergebot · 2023-10-12T01:42:05Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-12T01:42:10Z

Successfully rebased guangyey/inductor_channels_last_for_xpu onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout guangyey/inductor_channels_last_for_xpu && git pull --rebase)

pytorchmergebot · 2023-10-12T01:42:49Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

guangyey · 2023-10-12T05:31:52Z

@pytorchbot merge

pytorchmergebot · 2023-10-12T05:32:12Z

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

pytorchmergebot · 2023-10-12T05:34:38Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-10-12T05:56:52Z

Merge failed

Reason: 27 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

aten/src/ATen/native/Convolution.cpp

guangyey · 2023-10-12T06:08:02Z

@pytorchbot merge

pytorchmergebot · 2023-10-12T06:09:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

guangyey · 2023-10-12T06:23:19Z

@pytorchbot merge

pytorchmergebot · 2023-10-12T06:23:38Z

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

pytorchmergebot · 2023-10-12T06:26:30Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-10-12T06:37:47Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / build

Details for Dev Infra team

Raised by workflow job

guangyey · 2023-10-12T14:49:56Z

@pytorchbot merge

pytorchmergebot · 2023-10-12T14:51:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

github-actions bot added module: cpu CPU specific problem (e.g., perf, algorithm) ciflow/inductor labels Oct 11, 2023

pytorch-bot bot added the topic: not user facing topic category label Oct 11, 2023

pytorchbot added the open source label Oct 11, 2023

cpuhrsch requested review from eellison and mingfeima October 11, 2023 07:08

cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 11, 2023

jansel approved these changes Oct 11, 2023

View reviewed changes

eellison approved these changes Oct 11, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2023

pytorchmergebot added the merging label Oct 11, 2023

EikanWang approved these changes Oct 12, 2023

View reviewed changes

pytorchmergebot removed the merging label Oct 12, 2023

EikanWang requested changes Oct 12, 2023

View reviewed changes

aten/src/ATen/native/Convolution.cpp Outdated Show resolved Hide resolved

pytorchmergebot added the merging label Oct 12, 2023

pytorchmergebot removed the merging label Oct 12, 2023

EikanWang approved these changes Oct 12, 2023

View reviewed changes

guangyey added 2 commits October 12, 2023 13:59

support channel last for xpu in inductor layout opt path

9b5328b

correct return value

074222b

pytorchmergebot added the merging label Oct 12, 2023

pytorchmergebot added Merged and removed merging labels Oct 12, 2023

pytorchmergebot closed this in 918054f Oct 12, 2023

[Inductor] support channel last for xpu conv in inductor layout opt path #111018

[Inductor] support channel last for xpu conv in inductor layout opt path #111018

Uh oh!

Conversation

guangyey commented Oct 11, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Solution

Uh oh!

pytorch-bot bot commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111018

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

guangyey commented Oct 11, 2023

Uh oh!

guangyey commented Oct 11, 2023

Uh oh!

guangyey commented Oct 11, 2023

Uh oh!

guangyey commented Oct 11, 2023

Uh oh!

pytorchmergebot commented Oct 11, 2023

Merge started

Uh oh!

guangyey commented Oct 12, 2023

Uh oh!

guangyey commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Merge started

Uh oh!

guangyey commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Merge started

Uh oh!

pytorchmergebot commented Oct 12, 2023

Merge failed

Uh oh!

Uh oh!

guangyey commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Merge started

Uh oh!

guangyey commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Merge started

Uh oh!

pytorchmergebot commented Oct 12, 2023

Merge failed

Uh oh!

guangyey commented Oct 12, 2023

Uh oh!

pytorchmergebot commented Oct 12, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

guangyey commented Oct 11, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Oct 11, 2023 •

edited

Loading