KEMBAR78
checkpoint_sequential warns if use_reentrant not passed explicitly by soulitzer · Pull Request #114158 · pytorch/pytorch · GitHub
Skip to content

Conversation

@soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Nov 20, 2023

Use warning text for deprecation message.

@soulitzer soulitzer requested a review from albanD November 20, 2023 19:43
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114158

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 74741b5 with merge base 9d2425c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer added release notes: autograd release notes category topic: deprecation topic category labels Nov 20, 2023
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small test would be good but SGTM

@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: autograd release notes category topic: deprecation topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants