KEMBAR78
[MPS] Fix `abs` for complex types by pytorchbot · Pull Request #126096 · pytorch/pytorch · GitHub
Skip to content

[MPS] Fix abs for complex types #126096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

[MPS] Fix abs for complex types #126096

merged 1 commit into from
May 13, 2024

Conversation

pytorchbot
Copy link
Collaborator

By calling realPartOfTensor: if input type is complex on Sonoma and fall back to at::view_as_real trick on Ventura.

Split unary_op template into unary_op and unary_op_noresize, which skips resize and empty checks

Marked abs, isclose and nn.functional.softsign OpInfo tests as supported by complex types

Fixes #125135

@malfet @pytorchbot
[MPS] Fix abs for complex types (#125662)
22cc98d 
By calling `realPartOfTensor:` if input type is complex on Sonoma and fall back to `at::view_as_real` trick on Ventura.

Split `unary_op` template into `unary_op` and `unary_op_noresize`, which skips resize and empty checks

Marked `abs`, `isclose` and `nn.functional.softsign` OpInfo tests as supported by complex types

Fixes #125135

Pull Request resolved: #125662
Approved by: https://github.com/kulinseth

(cherry picked from commit 0fd1fc1)
@pytorchbot pytorchbot mentioned this pull request May 13, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented May 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126096

Note: Links to docs will display an error until the docs builds have been completed.

❌ 48 New Failures

As of commit 22cc98d with merge base 86a2d67 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels May 13, 2024
@atalman atalman mentioned this pull request May 13, 2024
Closed
@huydhn huydhn merged commit d983cb7 into release/2.3 May 13, 2024
@github-actions github-actions bot deleted the cherry-pick-125662-by-pytorch_bot_bot_ branch June 13, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) open source release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pytorchbot @huydhn @malfet