Fix SobolEngine default dtype handling #126781
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126781
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d15dc6b with merge base 980f5ac ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
No, default dtype is still float32, notice context manager above the test that validates it (but probably can add it to the test itself, it it's not clear) |
malfet
added
topic: bc breaking
| return result | ||
|
|
||
| def draw_base2(self, m: int, out: Optional[torch.Tensor] = None, | ||
| dtype: torch.dtype = torch.float32) -> torch.Tensor: |
There was a problem hiding this comment.
docstring needs updating below
There was a problem hiding this comment.
I'm struggling a bit between Default: None and just deleting this line...
There was a problem hiding this comment.
deleting would be pretty badly bc-breaking no?
There was a problem hiding this comment.
I've meant delete Default: None line in the doc which does not add much clarify, as in the argument description its already said its optional
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
5 participants
Noneand fetch it value viatorch.get_default_dtype()call if not definedFixes #126478