KEMBAR78
[ROCm] Add AMDSMI support for UUID input by jataylo · Pull Request #129741 · pytorch/pytorch · GitHub
Skip to content

Conversation

@jataylo
Copy link
Collaborator

@jataylo jataylo commented Jun 28, 2024

Adds support for for using UUIDs for AMDSMI utilities in PyTorch via CUDA_VISIBLE_DEVICES/HIP_VISIBLE_DEVICES.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @hongxiayang @naromero77amd

@jataylo jataylo added ciflow/trunk Trigger trunk jobs on your pull request ciflow/rocm Trigger "default" config CI on ROCm labels Jun 28, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129741

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 71e1203 with merge base 0e4d426 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Jun 28, 2024
@jithunnair-amd jithunnair-amd added the rocm This tag is for PRs from ROCm team label Jul 1, 2024
@jataylo
Copy link
Collaborator Author

jataylo commented Jul 11, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased amdsmi-uuid onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout amdsmi-uuid && git pull --rebase)

@jataylo jataylo marked this pull request as ready for review July 11, 2024 19:54
@jataylo jataylo requested a review from eqy as a code owner July 11, 2024 19:54
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 13, 2024
@pruthvistony pruthvistony marked this pull request as draft July 29, 2024 21:28
@jataylo jataylo requested a review from jithunnair-amd July 31, 2024 14:09
@jataylo jataylo marked this pull request as ready for review August 1, 2024 09:17
@jataylo jataylo requested a review from syed-ahmed as a code owner August 1, 2024 09:17
@jataylo
Copy link
Collaborator Author

jataylo commented Aug 13, 2024

cc: @malfet @xw285cornell

@pruthvistony
Copy link
Collaborator

@malfet ,
Please review this PR.

@jataylo
Copy link
Collaborator Author

jataylo commented Sep 10, 2024

Hey @malfet @xw285cornell any comments on this one?

@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jataylo jataylo added the topic: new features topic category label Oct 14, 2024
@jataylo
Copy link
Collaborator Author

jataylo commented Oct 14, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased amdsmi-uuid onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout amdsmi-uuid && git pull --rebase)

@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source release notes: rocm mandatorylabel rocm This tag is for PRs from ROCm team topic: new features topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants