Fix mkl-static issue for Windows. #132401

pytorchbot · 2024-08-01T13:02:22Z

Background:
We found the pytorch Windows release/2.4 performance regression: #130619

After some debug works, I found the pytorch Windows static mkl build options are wrong:

Thread lib is wrong.
Miss openmp lib and config.

Debug history: #130619 (comment) and #130619 (comment)

This PR will fix mkl-static build options issue.

Reference:

https://www.intel.com/content/www/us/en/developer/tools/oneapi/onemkl-link-line-advisor.html#gs.c6izlg

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Background: We found the pytorch Windows release/2.4 performance regression: #130619 After some debug works, I found the pytorch Windows static mkl build options are wrong: <img width="1049" alt="image" src="https://github.com/user-attachments/assets/38692142-bfca-4c98-8092-6e105c82bb13"> 1. Thread lib is wrong. 2. Miss `openmp` lib and config. > Debug history: #130619 (comment) and #130619 (comment) This PR will fix `mkl-static` build options issue. <img width="863" alt="image" src="https://github.com/user-attachments/assets/834f6cee-7e6d-4d74-b2bc-8a270f05e429"> Reference: <img width="482" alt="image" src="https://github.com/user-attachments/assets/8184dadb-f230-4062-a49f-51df1d7285f5"> https://www.intel.com/content/www/us/en/developer/tools/oneapi/onemkl-link-line-advisor.html#gs.c6izlg Pull Request resolved: #130697 Approved by: https://github.com/jgong5, https://github.com/atalman (cherry picked from commit f1456c7)

pytorch-bot · 2024-08-01T13:02:24Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132401

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 41 Cancelled Jobs

As of commit e60cdf5 with merge base b66e3f0 ():

NEW FAILURES - The following jobs have failed:

pull / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, linux.12xlarge) (gh)
test_repeat_truncated
pull / linux-focal-py3.12-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
dynamo/test_dynamic_shapes.py::DynamicShapesMiscTests::test_outside_linear_module_free_dynamic_shapes

CANCELLED JOBS - The following jobs were cancelled. Please retry:

pull / linux-focal-cuda11.8-py3.10-gcc9 / build (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 4, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 4, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-cuda12.4-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge.nvidia.gpu) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10-onnx / test (default, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 1, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 2, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (default, 3, 3, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 2, 2, linux.2xlarge) (gh)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorchbot mentioned this pull request Aug 1, 2024

Fix mkl-static issue for Windows. #130697

Closed

atalman mentioned this pull request Aug 1, 2024

[v2.4.1] Release Tracker #132400

Closed

pytorchbot added the open source label Aug 1, 2024

atalman approved these changes Aug 1, 2024

View reviewed changes

atalman merged commit f6fb80b into release/2.4 Aug 1, 2024

github-actions bot deleted the cherry-pick-130697-by-pytorch_bot_bot_ branch September 1, 2024 02:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix mkl-static issue for Windows. #132401

Fix mkl-static issue for Windows. #132401

Uh oh!

pytorchbot commented Aug 1, 2024

Uh oh!

pytorch-bot bot commented Aug 1, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix mkl-static issue for Windows. #132401

Fix mkl-static issue for Windows. #132401

Uh oh!

Conversation

pytorchbot commented Aug 1, 2024

Uh oh!

pytorch-bot bot commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132401

❌ 2 New Failures, 41 Cancelled Jobs

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot bot commented Aug 1, 2024 •

edited

Loading