KEMBAR78
Enable Windows Arm64 by iremyux · Pull Request #133088 · pytorch/pytorch · GitHub
Skip to content

Conversation

@iremyux
Copy link
Collaborator

@iremyux iremyux commented Aug 9, 2024

This PR enables Pytorch for Windows on Arm64 - CPU only.
Currently, there aren't any checks in place to build and test for Windows on Arm64, but we're working to implement those as soon as possible.
We recommend using Arm Performance Libraries (APL) as a BLAS option, which is introduced in this PR.

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133088

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 4 Unrelated Failures

As of commit 69df17a with merge base 2827bef (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@iremyux iremyux added module: windows Windows support for PyTorch ciflow/binaries Trigger all binary build and upload jobs on the PR labels Aug 9, 2024
@iremyux iremyux changed the title Enable windows arm64 [WIP] Enable Windows Arm64 Aug 9, 2024
@iremyux iremyux removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Aug 9, 2024
@iremyux iremyux closed this Aug 9, 2024
@iremyux iremyux reopened this Aug 9, 2024
@iremyux iremyux marked this pull request as ready for review August 9, 2024 15:41
@iremyux iremyux changed the title [WIP] Enable Windows Arm64 Enable Windows Arm64 Aug 9, 2024
@albanD albanD requested review from a team and malfet August 12, 2024 17:09
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 12, 2024
@ghost ghost added release notes: build release notes category and removed release notes: build release notes category labels Oct 23, 2024
@ezyang ezyang removed their request for review October 24, 2024 03:54
@ezyang
Copy link
Contributor

ezyang commented Oct 24, 2024

@malfet you've got this one?

@malfet
Copy link
Contributor

malfet commented Oct 24, 2024

you've got this one?

Yeah, I waited for some reference to upstream issue why this is needed

@malfet
Copy link
Contributor

malfet commented Oct 24, 2024

@pytorchbot merge -f "It probably works"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor module: windows Windows support for PyTorch open source release notes: build release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants