KEMBAR78
Enable additional tests for MPS CI runs by skotapati · Pull Request #134356 · pytorch/pytorch · GitHub
Skip to content

Enable additional tests for MPS CI runs #134356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

Enable additional tests for MPS CI runs #134356

wants to merge 27 commits into from

Conversation

@skotapati
Copy link
Collaborator

@skotapati skotapati commented Aug 23, 2024 •
edited by pytorch-bot bot
Loading

@skotapati skotapati added the keep-going Don't stop on first failure, keep running tests until the end label Aug 23, 2024
@skotapati skotapati requested review from kulinseth and malfet August 23, 2024 18:45
@skotapati skotapati self-assigned this Aug 23, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134356

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 34705ca with merge base 38114ec (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@skotapati skotapati requested a review from albanD August 23, 2024 18:54
@skotapati
Copy link
Collaborator Author

Note that test_nn.py is also being looked at by #134184

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Aug 23, 2024
@albanD albanD removed their request for review August 23, 2024 21:13
This was referenced Aug 26, 2024
Closed
Closed
@skotapati skotapati force-pushed the dev/skotapati/mem_format_testing branch from 4f1aca3 to c3ca705 Compare August 27, 2024 19:44
malfet
malfet requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use skipIfMPS unless there is a hard crash, if so, please create an issue that tracks fixing hard crash

Also, instead of expectedFailures due to unsupported types, use dtypesIfMPS

@skotapati skotapati marked this pull request as ready for review September 6, 2024 19:46
@skotapati skotapati requested review from a team and mruberry as code owners September 6, 2024 19:46
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 9, 2024
malfet
malfet reviewed Sep 10, 2024
View reviewed changes
@skotapati skotapati force-pushed the dev/skotapati/mem_format_testing branch from 502d792 to d5d50ab Compare September 13, 2024 06:06
@skotapati skotapati added module: mps Related to Apple Metal Performance Shaders framework ciflow/mps Run MPS tests (subset of trunk) labels Sep 13, 2024
@skotapati skotapati force-pushed the dev/skotapati/mem_format_testing branch from 0e0306c to 2984e61 Compare September 23, 2024 22:39
@pytorchmergebot
Copy link
Collaborator

Successfully rebased dev/skotapati/mem_format_testing onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout dev/skotapati/mem_format_testing && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the dev/skotapati/mem_format_testing branch from f43f93a to d328506 Compare October 3, 2024 16:40
@skotapati
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@skotapati
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@skotapati skotapati requested a review from huydhn October 4, 2024 18:13
@skotapati
Copy link
Collaborator Author

I'm trying to figure out why we're seeing the timeout for the [trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable)](https://hud.pytorch.org/pr/pytorch/pytorch/134356#31059601049) job

@huydhn could I get a review if possible? I don't think any of the changes I made should have broken that test

@skotapati skotapati removed the keep-going Don't stop on first failure, keep running tests until the end label Oct 4, 2024
@skotapati
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@eqy eqy eqy approved these changes

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@albanD albanD Awaiting requested review from albanD

Assignees

@skotapati skotapati

Labels

ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: mps Related to Apple Metal Performance Shaders framework open source release notes: nn release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@skotapati @pytorchmergebot @huydhn @eqy @malfet @ezyang @pytorchbot