Do not use <filesystem> on Linux (#134494)
#134604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because right now it leads to symbol conflict from binary builds. Use of `std::filesystem::file_exists` was introduced by pytorch#126601 and in this PR it is replaced with a very straightforward implementation that calls `stat` on the given path, which is a classic C-way of checking for the file existence. This PR should be reverted once one figures out how to keep `std::filesystem` methods linked into the binary private Fixes symptoms of pytorch#133437 Pull Request resolved: pytorch#134494 Approved by: https://github.com/atalman, https://github.com/d4l3k
pytorch-bot
bot
added
oncall: distributed
|
Please note, no change to: |
kit1980
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because right now it leads to symbol conflict from binary builds. Use of
std::filesystem::file_existswas introduced by #126601 and in this PR it is replaced with a very straightforward implementation that callsstaton the given path, which is a classic C-way of checking for the file existence.This PR should be reverted once one figures out how to keep
std::filesystemmethods linked into the binary privateFixes symptoms of #133437
Pull Request resolved: #134494
Approved by: https://github.com/atalman, https://github.com/d4l3k
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o