🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134770

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ddae7f1 with merge base 4fcd15a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Another approach would be emitting a one-time warning and re-dispatch to cpu here :)

Another approach would be emitting a one-time warning and re-dispatch to cpu here :)

I like this option. This is what I was going to do. It's actually quite easy to do in aten/src/ATen/native/Convolution.cpp.

https://github.com/pytorch/pytorch/pull/134770/files#diff-2b02a4fc9ee55c0e5e6c3ca50de5211843685b34b7f3fd709710b09504ccca78L381-L387

Should this be updated as well?

edit: Reviewed on mobile. Not sure why the code snippet didn't get included.

Yeah that as well. Updated the PR so we can close the original issue of misleading error message while the work for a proper workaround happens.

I like this option. This is what I was going to do. It's actually quite easy to do in aten/src/ATen/native/Convolution.cpp.

That sounds good to me. Let me know if you'd still like to make a PR for that. Otherwise I'll add it to my todo list.

That sounds good to me. Let me know if you'd still like to make a PR for that. Otherwise I'll add it to my todo list.

I don't want to add to your workload if you're busy. Current solution proposed in this PR also LGTM. I can make a quick attempt and we can see if special casing is a solution we want to move forward with.

@pytorchbot merge

This PR needs to be approved by an authorized maintainer before merge.

@pytorchbot merge -f "Lint is green and this is a error only change"

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team