Param fixes in docstring #136097
Closed
Param fixes in docstring #136097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sentient07
requested review from
albanD,
ezyang,
fmassa,
jbschlosser,
mikaylagawarecki,
soulitzer and
soumith
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136097
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 28cbfe4 with merge base b82122b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
reviewed
Sep 14, 2024
torch/nn/attention/flex_attention.py
Outdated
| KV_BLOCK_SIZE (int): Block size of block mask for each query. | ||
| Q_BLOCK_SIZE (int): Block size of block mask for each key/value. | ||
| _compile (bool): Whether to compile the mask creation. | ||
| BLOCK_SIZE (int or Tuple[int, int]): Block size for the block mask. If a single int is provided, |
There was a problem hiding this comment.
"is provided," - it ends suddenly with a comma?
There was a problem hiding this comment.
Sorry for the oversight, should be fixed now
ezyang
approved these changes
Sep 21, 2024
ezyang
added
release notes: python_frontend
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong param names in docstrings. cc: @kit1980