[lintrunner] auto apply formatting changes as suggestions #136239

PaliC · 2024-09-17T23:54:21Z

(Remove spurious cc)

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec

pytorch-bot · 2024-09-17T23:54:26Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136239

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d9175c6 with merge base 9629835 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn · 2024-09-20T22:31:06Z

.github/workflows/lint.yml

        .github/scripts/lintrunner.sh

+  # NB: This doesn't work with forked PR https://github.com/parkerbxyz/suggest-changes/issues/33 :(
+  lintrunner-autoformat:


Let's make this run only when lint fails. Hopefully, people won't need it most of the time

~~Also, I don't think the review can be blank https://github.com/pytorch/pytorch/actions/runs/10967111239/job/30456284103?pr=136382#step:5:220, and passing lint means an empty review~~

Ah, I missed the checking for changes step below.

.github/workflows/lint.yml

huydhn

Stamped. I have some comments, so plz address them before landing

.github/workflows/lint.yml

huydhn · 2024-09-20T23:15:53Z

Btw, I still see --all-files is being used in https://github.com/pytorch/pytorch/actions/runs/10967418917/job/30457139818?pr=136382#step:5:218 in .github/scripts/lintrunner.sh here https://github.com/pytorch/pytorch/blob/main/.github/scripts/lintrunner.sh#L36

huydhn · 2024-09-21T00:11:16Z

Just FYI, this might do what we need https://github.com/pytorch/pytorch/pull/136391/files#diff-62d24ff39ccbf6d5625bcf6675cf941997898f591f3044ad694649c17ca1cc90. Instead of using pull_request, we will use pull_request_target to main, which cover both regular and forked PR.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target says that the permission is there:

For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission

You can try to follow up in a separate PR after this. Testing this can only be done in main after the new workflow lands though

PaliC · 2024-09-24T15:14:09Z

@pytorchbot merge

pytorchmergebot · 2024-09-24T15:16:04Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-24T15:16:21Z

Merge failed

Reason: 14 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

PaliC · 2024-09-25T00:32:15Z

@pytorchbot rebase

.github/workflows/lint-autoformat.yml

pytorchmergebot · 2024-09-25T00:33:44Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-09-25T00:33:47Z

Successfully rebased palic/autolint onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout palic/autolint && git pull --rebase)

PaliC · 2024-09-25T00:33:57Z

@pytorchbot merge

pytorchmergebot · 2024-09-25T00:35:46Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-25T00:41:17Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / workflow-checks / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

eqy · 2024-09-25T23:03:40Z

.github/workflows/lint.yml

 concurrency:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name == 'workflow_dispatch' }}
-  cancel-in-progress: true
+  cancel-in-progress: true


Is the "no newline at EOF" intentional?

PaliC · 2024-09-25T23:04:07Z

@pytorchbot merge

pytorchmergebot · 2024-09-25T23:05:44Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-25T23:05:52Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / workflow-checks / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

PaliC · 2024-09-25T23:22:56Z

@pytorchbot merge

pytorchmergebot · 2024-09-25T23:24:32Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-25T23:40:04Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

PaliC · 2024-09-26T17:58:45Z

@pytorchbot merge

pytorchmergebot · 2024-09-26T18:00:57Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-26T23:59:26Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

PaliC · 2024-09-27T00:49:32Z

@pytorchbot merge

pytorchmergebot · 2024-09-27T00:51:10Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added the release notes: releng release notes category label Sep 17, 2024

pytorch-bot bot added the topic: not user facing topic category label Sep 20, 2024

PaliC marked this pull request as ready for review September 20, 2024 22:18

PaliC requested a review from a team as a code owner September 20, 2024 22:18

huydhn reviewed Sep 20, 2024

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

huydhn reviewed Sep 20, 2024

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

huydhn reviewed Sep 20, 2024

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

huydhn approved these changes Sep 20, 2024

View reviewed changes

huydhn reviewed Sep 20, 2024

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 24, 2024

pytorchmergebot added the merging label Sep 24, 2024

pytorchmergebot removed the merging label Sep 24, 2024

huydhn reviewed Sep 25, 2024

View reviewed changes

.github/workflows/lint-autoformat.yml Outdated Show resolved Hide resolved

pytorchmergebot force-pushed the palic/autolint branch from 2505062 to 56fd693 Compare September 25, 2024 00:33

pytorchmergebot added the merging label Sep 25, 2024

pytorchmergebot removed the merging label Sep 25, 2024

huydhn added the test-config/default label Sep 25, 2024

huydhn removed the request for review from shubhambhokare1 September 25, 2024 22:25

PaliC added 3 commits September 25, 2024 15:45

add shell bash

83c527c

add shell bash

18e809c

remove copying over the file

2c73207

eqy approved these changes Sep 25, 2024

View reviewed changes

pytorchmergebot added the merging label Sep 25, 2024

pytorchmergebot removed the merging label Sep 25, 2024

fix concurrency

6b353e7

pytorchmergebot added the merging label Sep 25, 2024

pytorchmergebot removed the merging label Sep 25, 2024

fix versioning

d9175c6

pytorchmergebot added the merging label Sep 26, 2024

pytorchmergebot closed this in adc77a9 Sep 27, 2024

pytorchmergebot added Merged and removed merging labels Sep 27, 2024

clee2000 mentioned this pull request Oct 29, 2024

Automatic linter fixing for PRs #133715

Closed

clee2000 mentioned this pull request Nov 15, 2024

Automatically run "lintrunner -a" when needed and create review comments with autofixes #113079

Closed

taras-janea mentioned this pull request Oct 12, 2025

Dev environment does not support windows #133619

Closed

[lintrunner] auto apply formatting changes as suggestions #136239

[lintrunner] auto apply formatting changes as suggestions #136239

Uh oh!

Conversation

PaliC commented Sep 17, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136239

✅ No Failures

Uh oh!

huydhn Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

huydhn Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huydhn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

huydhn commented Sep 20, 2024

Uh oh!

huydhn commented Sep 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaliC commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 24, 2024

Merge failed

Uh oh!

PaliC commented Sep 25, 2024

Uh oh!

Uh oh!

pytorchmergebot commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Uh oh!

PaliC commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 25, 2024

Merge failed

Uh oh!

eqy Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

PaliC commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 25, 2024

Merge failed

Uh oh!

PaliC commented Sep 25, 2024

Uh oh!

pytorchmergebot commented Sep 25, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 25, 2024

Merge failed

Uh oh!

PaliC commented Sep 26, 2024

Uh oh!

pytorchmergebot commented Sep 26, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 26, 2024

PaliC commented Sep 17, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 17, 2024 •

edited

Loading

huydhn Sep 20, 2024 •

edited

Loading

huydhn commented Sep 21, 2024 •

edited

Loading