KEMBAR78
[MPS] Implement `isposinf` and `isneginf` by malfet · Pull Request #136689 · pytorch/pytorch · GitHub
Skip to content

[MPS] Implement isposinf and isneginf #136689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] Implement isposinf and isneginf #136689

wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 25, 2024 •
edited
Loading

Not sure, why isinf is a composite op, but those needs to be implemented by hand.

Implementation is a trivial call to

[mpsGraph equalWithPrimaryTensor:input
                 secondaryTensor:[mpsGraph constantWithScalar:std::numeric_limits<T>::infinity()
                                                     dataType:input.dataType]]

@malfet
[MPS] Implement isposinf and isneginf
d1fff03 
Not sure, why `isinf` is a composite op, but those needs to be implemented by hand, but why not

Implementation is a trivial call to
```objc
[mpsGraph equalWithPrimaryTensor:input
                 secondaryTensor:[mpsGraph constantWithScalar:std::numeric_limits<T>::infinity()
                                                     dataType:input.dataType]]
```
@malfet malfet requested a review from kulinseth as a code owner September 25, 2024 22:26
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136689

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d1fff03 with merge base a259fbf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Sep 25, 2024
@malfet malfet added the topic: improvements topic category label Sep 25, 2024
@malfet malfet requested a review from albanD September 25, 2024 22:26
@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@malfet
Copy link
Contributor Author

malfet commented Sep 26, 2024

@pytorchbot merge -f "MPS test + lint are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet/add-mps-posneg-inf branch October 27, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @Skylion007