KEMBAR78
[CI] Populate `JOB_ID` for MPS tests by malfet · Pull Request #136791 · pytorch/pytorch · GitHub
Skip to content

[CI] Populate JOB_ID for MPS tests #136791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[CI] Populate JOB_ID for MPS tests #136791

wants to merge 3 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 26, 2024 •
edited
Loading

Move get-job-id steps before running the tests and copy-n-paste environment variables from _mac-test.yml added in #113099

Should fix the following warning during MPS test run:

/Users/ec2-user/runner/_work/pytorch/pytorch/tools/stats/upload_metrics.py:147: UserWarning: Not emitting metrics for td_test_failure_stats_v2. Missing job_id. Please set the JOB_ID environment variable to pass in this value.
  warn(f"Not emitting metrics for {metric_name}. {e}")

@malfet
[CI] Populate JOB_ID for MPS tests
753775c 
Copy-n-paste code from `_mac-test.yml` added in #113099
@malfet malfet requested a review from a team as a code owner September 26, 2024 20:42
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136791

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 6e5f8d5 with merge base 3c542ce (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 26, 2024
@malfet malfet added the ciflow/mps Run MPS tests (subset of trunk) label Sep 26, 2024
albanD
albanD approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@malfet
Copy link
Contributor Author

malfet commented Sep 26, 2024

@pytorchbot merge -f "Lint is green and warning is gone"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet/populate-job-id-for-mps-tests branch October 28, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@izaitsevfb izaitsevfb izaitsevfb approved these changes

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @albanD @izaitsevfb