KEMBAR78
docs: clarify alias usage for `x` parameter in vector_norm function by thomasXwang · Pull Request #136921 · pytorch/pytorch · GitHub
Skip to content

Conversation

@thomasXwang
Copy link
Contributor

  • Added a note in the documentation specifying that the input parameter can be used as an alias for x.

Fixes #136560

- Added a note in the documentation specifying that the `input` parameter can be used as an alias for `x`.
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136921

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 14f63d1 with merge base a54b692 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Sep 28, 2024
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
@ezyang
Copy link
Contributor

ezyang commented Sep 28, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#136928

Details for Dev Infra team Raised by workflow job

@lezcano
Copy link
Collaborator

lezcano commented Sep 29, 2024

nb. This is an issue with all functions in linalg. We should probably bite the bullet and just change the names of the inputs in native_functions.yaml for all of them (I'd hope not many people are using the keyword input=...).

@ezyang
Copy link
Contributor

ezyang commented Sep 30, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@thomasXwang thomasXwang deleted the thomasXwang-patch-1 branch September 30, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: linalg_frontend release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The doc of linalg.vector_norm() should say there is x or input parameter

5 participants