KEMBAR78
[ONNX] Set USE_EXPERIMENTAL_LOGIC to True by justinchuby · Pull Request #137296 · pytorch/pytorch · GitHub
Skip to content

[ONNX] Set USE_EXPERIMENTAL_LOGIC to True #137296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[ONNX] Set USE_EXPERIMENTAL_LOGIC to True #137296

wants to merge 5 commits into from

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Oct 3, 2024 •
edited
Loading

This sets dynamo_export to use the new export logic. The legacy dynamo export logic will be removed as a follow up.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137296

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 11 Pending

As of commit 5b19f1d with merge base 6cda572 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 3, 2024
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: new features topic category labels Oct 3, 2024
@justinchuby justinchuby requested a review from xadupre October 3, 2024 19:20
@justinchuby justinchuby added this to the 2.6.0 milestone Oct 3, 2024
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 4, 2024
@titaiwangms titaiwangms self-assigned this Oct 7, 2024
@titaiwangms
Copy link
Collaborator

Depends on #135403?

@justinchuby
Copy link
Collaborator Author

@pytorchbot rebase

@justinchuby justinchuby added topic: bc breaking topic category and removed topic: new features topic category labels Nov 21, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased justinchu/default-ep onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout justinchu/default-ep && git pull --rebase)

@justinchuby justinchuby modified the milestones: 2.6.0, 2.7.0 Nov 24, 2024
@justinchuby
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased justinchu/default-ep onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout justinchu/default-ep && git pull --rebase)

@titaiwangms
Copy link
Collaborator

One of the issue I found is that the deprecation of old ONNXProgram is bc breaking in terms of the consistency: pytorch/tutorials#3191

We might need to inform users somewhere. And torch tutorial needs to be updated regards to the new API usages.

titaiwangms
titaiwangms reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest turn fallback to False in dynamo_export, and get rid of the tests. After all, this is not the most recommended API.

@justinchuby
[ONNX] Set USE_EXPERIMENTAL_LOGIC to True
2e0a696 
This will set dynamo_export to use the new logic.
@justinchuby
Clean up tests
f575c9d
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 28, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results January 28, 2025 20:09 Error
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results January 28, 2025 20:09 Error
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results January 28, 2025 20:09 Error
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 21:02 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 21:02 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 21:02 Inactive
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "All related tests passed"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

fyi @borisfom

@atalman atalman mentioned this pull request Apr 3, 2025
Closed
65 tasks
@GdoongMathew GdoongMathew mentioned this pull request May 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

@xadupre xadupre Awaiting requested review from xadupre

Assignees

@titaiwangms titaiwangms

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bc breaking topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @titaiwangms @pytorchmergebot @bdhirsh @pytorchbot