KEMBAR78
Extend cuda_flip to unsigned types by malfet · Pull Request #137781 · pytorch/pytorch · GitHub
Skip to content

Extend cuda_flip to unsigned types #137781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Extend cuda_flip to unsigned types #137781

wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 11, 2024 •
edited
Loading

Using AT_DISPATCH_V2

Test plan: python3 -c "import torch;print(torch.randint(0, 100, (4, 4), dtype=torch.uint16, device='cuda').flip(0))"
Fixes #137770

@malfet
Extend cuda_flip to unsigned types
47160a7 
Using AT_DISPATCH_V2

Fixes #137770
@malfet malfet requested review from a team, ezyang and ptrblck October 11, 2024 14:34
@malfet malfet requested review from eqy and syed-ahmed as code owners October 11, 2024 14:34
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137781

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 47160a7 with merge base e30c55e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cuda release notes category label Oct 11, 2024
@malfet malfet added the topic: improvements topic category label Oct 11, 2024
@malfet
Copy link
Contributor Author

malfet commented Oct 11, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet/extend-flip-to-unsigned-types branch November 11, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@ptrblck ptrblck Awaiting requested review from ptrblck

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: cuda release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash when first convert data type and then flip

3 participants

@malfet @pytorchmergebot @Skylion007