KEMBAR78
Updates reference to _runner-determinator.yml workflow, from current version to main version. by jeanschmidt · Pull Request #137791 · pytorch/pytorch · GitHub
Skip to content

Updates reference to _runner-determinator.yml workflow, from current version to main version. #137791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Updates reference to _runner-determinator.yml workflow, from current version to main version. #137791

wants to merge 1 commit into from

Conversation

@jeanschmidt
Copy link
Contributor

Updates all references to runner determinator workflow (_runner-determinator.yml) from current cloned version to main version.

This enables the team to push updates to this workflow, like fixing bugs or pushing improvements, and have it immediately be reflected on all open PRs. So avoiding potentially breaking situations, empowering moving fast and fast and simple recover in case of bugs.

From:

jobs:
  get-label-type:
    uses: ./.github/workflows/_runner-determinator.yml

To:

jobs:
  get-label-type:
    uses: pytorch/pytorch/.github/workflows/_runner-determinator.yml@main

@jeanschmidt jeanschmidt requested a review from a team as a code owner October 11, 2024 17:05
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137791

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 0e19f23 with merge base b82000c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 11, 2024
@jeanschmidt jeanschmidt added ciflow/trunk Trigger trunk jobs on your pull request ciflow/nightly Trigger all jobs we run nightly (nightly.yml) labels Oct 11, 2024
@jeanschmidt jeanschmidt self-assigned this Oct 11, 2024
malfet
malfet reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it prevent people from being able to test any changes to this workflow on the pull request?

huydhn
huydhn approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder why we don't move this to test-infra, but this probably makes more sense as this is a PyTorch-only thing. If we need some tests here, we need to write a test workflow like https://github.com/pytorch/test-infra/blob/main/.github/workflows/test-setup-nvidia.yml that calls the GHA from PR head.

@zxiiro
Copy link
Collaborator

zxiiro commented Oct 11, 2024

Wouldn't it prevent people from being able to test any changes to this workflow on the pull request?

Yes. The workaround would be they update their PR to use the local version for testing but then runs the risk of folks needing to remember to remove that from their workflow before approving and merging.

zxiiro
zxiiro approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@zxiiro zxiiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@jeanschmidt
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • EasyCLA

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jeanschmidt jeanschmidt removed the request for review from ZainRizvi October 11, 2024 23:49
@jeanschmidt
Copy link
Contributor Author

@pytorchbot merge -f "easycla job does not exist"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • EasyCLA

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jeanschmidt
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased jeanschmidt/runner_determinator_from_main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout jeanschmidt/runner_determinator_from_main && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the jeanschmidt/runner_determinator_from_main branch from f8c6793 to 0e19f23 Compare October 11, 2024 23:56
@huydhn
Copy link
Contributor

huydhn commented Oct 12, 2024

@pytorchbot merge -f 'CI only changes, runner determinator and lint jobs have passed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@zxiiro
Copy link
Collaborator

zxiiro commented Oct 12, 2024 •
edited
Loading

"easycla job does not exist"

EasyCLA job does exist and I've seen it pass in other PRs. Its a job managed by the LF for all open source projects. I wonder why its missing here but we shouldn't ignore it.

@jeanschmidt
Copy link
Contributor Author

@zxiiro totally agree, we should not even allow -f to enable bypass this particular job.

I did rebase expecting it to run, and didn't try to -f for this reason.

@jeanschmidt jeanschmidt mentioned this pull request Oct 14, 2024
Closed
@github-actions github-actions bot deleted the jeanschmidt/runner_determinator_from_main branch November 14, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@zxiiro zxiiro zxiiro approved these changes

@huydhn huydhn huydhn approved these changes

Assignees

@jeanschmidt jeanschmidt

Labels

ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeanschmidt @zxiiro @pytorchmergebot @huydhn @malfet