KEMBAR78
RMSprop docs: add missing input "epsilon" by djv · Pull Request #137854 · pytorch/pytorch · GitHub
Skip to content

Conversation

@djv
Copy link
Contributor

@djv djv commented Oct 13, 2024

Adding a missing input argument in the docs for RMSprop. Like in the doc for AdamW https://pytorch.org/docs/stable/generated/torch.optim.AdamW.html

@djv djv requested review from albanD and janeyx99 as code owners October 13, 2024 05:35
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137854

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 66be7ab with merge base 3050f2e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks, approval contingent on the docs build passing

@janeyx99 janeyx99 added the topic: docs topic category label Oct 14, 2024
@janeyx99
Copy link
Contributor

@pytorchbot merge

docs preview is good

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 15, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD albanD removed their request for review October 15, 2024 15:15
@djv djv deleted the patch-2 branch October 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: optim topic: docs topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants