KEMBAR78
[CI] Run periodic jobs only on pytorch/pytorch repo by malfet · Pull Request #138874 · pytorch/pytorch · GitHub
Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 25, 2024

Github by default tries to not run periodic jobs on forks, see https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/disabling-and-enabling-a-workflow
But there is a special test repo called pytorch/canary, that will run those workflows for next 60 days, which is a waste of resources

Github by default tries to not run periodic jobs on forks, see https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/disabling-and-enabling-a-workflow
But there is a special test repo called `pytorch/canary`, that will run those workflows for next 60 days, which is a waste of resources
@malfet malfet requested a review from a team as a code owner October 25, 2024 00:50
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138874

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2bc6eb5 with merge base 889717a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 25, 2024
@facebook-github-bot facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Oct 25, 2024
@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request and removed module: rocm AMD GPU support for Pytorch labels Oct 25, 2024
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet
Copy link
Contributor Author

malfet commented Oct 25, 2024

Nice! Could you disable those perf benchmark jobs too, i.e. https://github.com/pytorch/pytorch/blob/main/.github/workflows/inductor-perf-test-nightly-aarch64.yml?

Wow, I've never realized how many periodic jobs we have... Almost every workflow has some periodic aspect to it

@ZainRizvi do we have numbers on resource utilization per github event type?

@huydhn
Copy link
Contributor

huydhn commented Oct 25, 2024

Wow, I've never realized how many periodic jobs we have... Almost every workflow has some periodic aspect to it

Yeah, it takes me by surprise too, I guess we just don't pay attention to canary. I don't see a big monthly bill from canary though https://torchci-git-wdvr-costanalysis-fbopensource.vercel.app/cost_analysis?startDate=2023-10-26&endDate=2024-10-25&granularity=month&groupby=workflow_name&chartType=line&yAxis=cost, still a waste nonetheless.

@malfet
Copy link
Contributor Author

malfet commented Oct 25, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@malfet
Copy link
Contributor Author

malfet commented Oct 25, 2024

@pytorchbot merge -f "Macs are gone"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet/restrict-periodic-to-pytorch branch November 25, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants