KEMBAR78
[BC-Breaking]Remove capture_pre_autograd_graph references in quantization by yushangdi · Pull Request #139505 · pytorch/pytorch · GitHub
Skip to content

[BC-Breaking]Remove capture_pre_autograd_graph references in quantization #139505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BC-Breaking]Remove capture_pre_autograd_graph references in quantization #139505

wants to merge 1 commit into from

Conversation

yushangdi
Copy link
Contributor

@yushangdi yushangdi commented Nov 1, 2024 •
edited
Loading

Summary:
As title

This is a BC-breaking change because graph produced by "capture_pre_autograd_graph" cannot be input to quantization anymore. But this is ok, since this API is deprecated for a while and is going to be deleted. We have removed all call sites of it.

We remove the deprecated API references in code, docs, and tests.

We also removed two tests that specific to capture_pre_autograd_graph API.

Test Plan: CI

Differential Revision: D65351887

cc @ezyang @gchanan

@yushangdi yushangdi requested a review from jerryzh168 as a code owner November 1, 2024 19:12
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139505

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 49f7be2 with merge base 498a780 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Nov 1, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65351887

@jerryzh168
Copy link
Contributor

cc @andrewor14 can you follow up on how does the change of training ir affect batchnorm op consolidation work?

@jerryzh168 jerryzh168 requested a review from andrewor14 November 1, 2024 19:43
@yushangdi
Copy link
Contributor Author

There are some test failures because a call to capture_pre_autograd_graph is recently added in #139054. I'd have to wait until it's imported internally to overwrite it.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65351887

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65351887

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65351887

@andrewor14
Copy link
Contributor

cc @andrewor14 can you follow up on how does the change of training ir affect batchnorm op consolidation work?

Sorry just saw this. It actually makes batch norm consolidation much lower priority, because export no longer produces the same batch norm ops as before. In particular, now we get aten.batch_norm directly in the graph, which is kind of already the "consolidated" op from export perspective. Users won't see aten.cudnn_batch_norm or aten._native_batch_norm_legit anymore if they use export_for_training

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65351887

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65351887

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65351887

@yushangdi
Copy link
Contributor Author

@andrewor14 @jerryzh168 We've removed all "capture_pre_autograd_graph" call sites now, and we are finally deleting it. Can I get a review for this PR? Thanks!!

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

8 similar comments
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@yushangdi
Copy link
Contributor Author

@pytorchbot merge -f landed internally

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 13, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: internally

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@yushangdi
Copy link
Contributor Author

@pytorchbot merge -f "landed internally"

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

3 similar comments
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@yushangdi
Copy link
Contributor Author

@pytorchbot merge -f "landed internally"

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

4 similar comments
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge), trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@tugsbayasgalan tugsbayasgalan tugsbayasgalan approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: bc-breaking Related to a BC-breaking change release notes: quantization release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yushangdi @facebook-github-bot @jerryzh168 @andrewor14 @pytorchmergebot @tugsbayasgalan