KEMBAR78
[CI] Fix xpu ci test with s3 cache by chuanqi129 · Pull Request #139604 · pytorch/pytorch · GitHub
Skip to content

[CI] Fix xpu ci test with s3 cache #139604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CI] Fix xpu ci test with s3 cache #139604

wants to merge 1 commit into from

Conversation

@chuanqi129
Copy link
Collaborator

@chuanqi129 chuanqi129 commented Nov 4, 2024 •
edited
Loading

Fix a regression caused by #121323
Works for #114850

@chuanqi129 chuanqi129 requested a review from a team as a code owner November 4, 2024 05:57
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139604

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit 9d5f234 with merge base 3179eb1 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 4, 2024
@chuanqi129 chuanqi129 added the ciflow/xpu Run XPU CI tasks label Nov 4, 2024
@chuanqi129 chuanqi129 requested a review from atalman November 4, 2024 22:11
atalman
atalman approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @chuanqi129 please add details of the failure (why this fix is needed) in the PR description: https://github.com/pytorch/pytorch/actions/runs/11658848522/job/32459872663#step:14:997

@malfet
Copy link
Contributor

malfet commented Nov 4, 2024

Thank you for the fix, and agree with what @atalman have said: explain why this change is needed (likely to fix a regression caused by #121323

@chuanqi129
Copy link
Collaborator Author

chuanqi129 commented Nov 5, 2024 •
edited
Loading

lgtm. @chuanqi129 please add details of the failure (why this fix is needed) in the PR description: https://github.com/pytorch/pytorch/actions/runs/11658848522/job/32459872663#step:14:997

@atalman @malfet Updated description. And will merge it directly to unblock XPU other PRs test

@etaf
Copy link
Collaborator

etaf commented Nov 5, 2024

@pytorchbot merge -f "unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chuanqi129 @malfet @etaf @pytorchmergebot @atalman @pytorchbot