KEMBAR78
Add setuptools and wheel to cp312, cp313 and cp313t for Manylinux2_28 builds by atalman · Pull Request #139636 · pytorch/pytorch · GitHub
Skip to content

Add setuptools and wheel to cp312, cp313 and cp313t for Manylinux2_28 builds #139636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add setuptools and wheel to cp312, cp313 and cp313t for Manylinux2_28 builds #139636

wants to merge 7 commits into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Nov 4, 2024 •
edited
Loading

Install setuptools and wheel dependencies for cp312, cp313, cp313t on Manylinux 2_28 images.
This should resolve

ModuleNotFoundError: No module named 'setuptools'

On PR: #138732

This issue was addressed on XPU images already. We should apply the same fix for the rest of the images instead of keeping it XPU specific.

@atalman atalman requested a review from jeffdaily as a code owner November 4, 2024 17:43
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 4, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139636

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e98d506 with merge base 87404b6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman marked this pull request as draft November 4, 2024 17:48
@atalman atalman changed the title Add Python install to Manylinux 2_28 docker builds Add setuptools and wheel to cp312 and cp313 Nov 4, 2024
@atalman atalman marked this pull request as ready for review November 4, 2024 20:05
@atalman atalman changed the title Add setuptools and wheel to cp312 and cp313 Add setuptools and wheel to cp312 and cp313 for Manylinux2_28 builds Nov 4, 2024
@atalman atalman changed the title Add setuptools and wheel to cp312 and cp313 for Manylinux2_28 builds Add setuptools and wheel to cp312, cp313 and cp313t for Manylinux2_28 builds Nov 4, 2024
huydhn
huydhn approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although it might be better if we could figure out a way to run this pip install command for all python version under /opt/python instead of hardcoding the list. Even for older version, I don't think there is any harm in installing setuptools and wheel, right?

@atalman
Copy link
Contributor Author

atalman commented Nov 4, 2024

Yes we can probably do it for all python versions.

@atalman
Copy link
Contributor Author

atalman commented Nov 5, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@chuanqi129 chuanqi129 chuanqi129 approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @huydhn @chuanqi129