KEMBAR78
Upgrade ROCm wheels to manylinux2_28 - 2 of 2 (binaries) by jithunnair-amd · Pull Request #141423 · pytorch/pytorch · GitHub
Skip to content

Upgrade ROCm wheels to manylinux2_28 - 2 of 2 (binaries) #141423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

Upgrade ROCm wheels to manylinux2_28 - 2 of 2 (binaries) #141423

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
59f253b
Upgrade binaries to ROCm6.2.4
jithunnair-amd Nov 23, 2024
30af7bc
Use manylinux2_28 docker images
jithunnair-amd Nov 23, 2024
792e2c7
ROCm manylinux2_28 wheels do not support pre-CXX11_ABI
jithunnair-amd Nov 23, 2024
913782a
Do not generate pre-cxx11 variants for ROCm
jithunnair-amd Nov 23, 2024
3237987
Update generated workflows for ROCm
jithunnair-amd Nov 23, 2024
5bcc22f
Lint
jithunnair-amd Nov 25, 2024
df04c80
ROCm only supports CXX_ABI=1 for manylinux2_28
jithunnair-amd Nov 14, 2024
24e1600
Changes to build_rocm.sh for manylinux2_28 wheels
jithunnair-amd Nov 14, 2024
da8172b
Install aotriton during wheel build instead of in manywheel docker im…
jithunnair-amd Nov 26, 2024
7a83903
Correct path for install_aotriton.sh
jithunnair-amd Nov 26, 2024
2182e4c
temporarily change docker image:tag to test new images
jeffdaily Nov 26, 2024
c7d753f
Merge branch 'main' into jnair/rocm_manylinux2_28_upgrade_binaries
jeffdaily Nov 26, 2024
ab408ff
fix image name formatting
jeffdaily Nov 26, 2024
97230dc
Update hash corresponding to https://github.com/pytorch/pytorch/pull/…
jithunnair-amd Nov 27, 2024
8ae9e23
Update hash corresponding to https://github.com/pytorch/pytorch/pull/…
jithunnair-amd Nov 28, 2024
83f140b
Revert temporary changes to use dockerhub manylinux images again
jithunnair-amd Nov 28, 2024
58ebc14
Set DESIRED_DEVTOOLSET to cxx11-abi for ROCm
jithunnair-amd Nov 29, 2024
44e83db
Lint
jithunnair-amd Dec 2, 2024
50e1f00
Use manylinux2_28 images for triton wheel build
jithunnair-amd Dec 2, 2024
e8c3733
Merge branch 'main' into jnair/rocm_manylinux2_28_upgrade_binaries
pruthvistony Dec 3, 2024
15fd5d7
libtinfo version update for Almalinux
jithunnair-amd Dec 3, 2024
ea90268
Use clang ldd for ROCm triton manylinux2_28 wheels
jithunnair-amd Dec 3, 2024
19b6416
Use manylinux2_28 matrix.docker-image entry for ROCm just so it sets …
jithunnair-amd Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update hash corresponding to 22d1987
  • Loading branch information
@jithunnair-amd
jithunnair-amd committed Nov 28, 2024
commit 8ae9e23fb206ef732d6c391a10ec7b5bed5f25c9
2 changes: 1 addition & 1 deletion .github/scripts/generate_binary_build_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def arch_type(arch_version: str) -> str:


# This can be updated to the release version when cutting release branch, i.e. 2.1
DEFAULT_TAG = "efc34a54fb31461a8b1aac0e95602d7785f9df20"
DEFAULT_TAG = "4f132cfbaed3236d1785ed641e2b0427dfc2eff7"

WHEEL_CONTAINER_IMAGES = {
"11.8": f"308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/manylinux-builder-cuda11.8:{DEFAULT_TAG}",
Expand Down
50 changes: 25 additions & 25 deletions .github/workflows/generated-linux-aarch64-binary-manywheel-nightly.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/generated-linux-binary-libtorch-cxx11-abi-main.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading