KEMBAR78
[EZ] Move slow job from CU12.1 to CU12.4 by malfet · Pull Request #142856 · pytorch/pytorch · GitHub
Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 11, 2024

I though it was migrated a while back

I though it was migrated a while back
@malfet malfet requested a review from Skylion007 December 11, 2024 08:25
@malfet malfet requested a review from a team as a code owner December 11, 2024 08:25
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142856

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c4babfb with merge base 30d8b30 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 11, 2024
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huydhn
Copy link
Contributor

huydhn commented Dec 11, 2024

Looks like there are still some remaining periodic 12.1 jobs

@malfet
Copy link
Contributor Author

malfet commented Dec 11, 2024

Looks like there are still some remaining periodic 12.1 jobs

Yes, there are periodic and inductor, I'll create separate PRs to move them (unless you've already did)
But I'm a bit curious, why wasn't the migration complete.
@atalman do you know?

@atalman
Copy link
Contributor

atalman commented Dec 11, 2024

@malfet I believe we need to update our CUDA update runbook: https://github.com/pytorch/builder/blob/main/CUDA_UPGRADE_GUIDE.MD
cc @tinglvv @weiwangmeta

@ZainRizvi
Copy link
Contributor

ZainRizvi commented Dec 11, 2024

@malfet I believe we need to update our CUDA update runbook: https://github.com/pytorch/builder/blob/main/CUDA_UPGRADE_GUIDE.MD cc @tinglvv @weiwangmeta

Prob best to update it with some future-proof instructions (e.g. "use cs.github.com with queries FOO and BAR to find all workflows where we need to update the CUDA version") in addition to the sample PRs, which will go stale over time

@malfet
Copy link
Contributor Author

malfet commented Dec 11, 2024

@malfet I believe we need to update our CUDA update runbook: https://github.com/pytorch/builder/blob/main/CUDA_UPGRADE_GUIDE.MD cc @tinglvv @weiwangmeta

IMO every time one is doing migration two things should happen:

  • Issue to be opened to track the migration
  • Issue is closed only when all jobs mentioning deprecated cuda version are removed

@atalman
Copy link
Contributor

atalman commented Dec 11, 2024

@malfet I believe we need to update our CUDA update runbook: pytorch/builder@main/CUDA_UPGRADE_GUIDE.MD cc @tinglvv @weiwangmeta

IMO every time one is doing migration two things should happen:

  • Issue to be opened to track the migration
  • Issue is closed only when all jobs mentioning deprecated cuda version are removed

Agree on this let us create an issue and follow thru rest of the migration there

@malfet
Copy link
Contributor Author

malfet commented Dec 11, 2024

@pytorchbot merge -f "Slow workflow is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants