KEMBAR78
Add 2 more APIs to the exposed public torch python APIs by manav-a · Pull Request #143380 · pytorch/pytorch · GitHub
Skip to content

Add 2 more APIs to the exposed public torch python APIs #143380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add 2 more APIs to the exposed public torch python APIs #143380

wants to merge 3 commits into from

Conversation

@manav-a
Copy link
Contributor

@manav-a manav-a commented Dec 17, 2024 •
edited
Loading

These two APIs are being used internally for some projects and need to be exposed as the build for this is done using OSS toolchain.

af8789c - this change hid most apis in torch python barring the ones explicitly specified breaking the build.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143380

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dc6f249 with merge base 6056efc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 17, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@manav-a
Copy link
Contributor Author

manav-a commented Dec 17, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 17, 2024
@manav-a
Copy link
Contributor Author

manav-a commented Dec 17, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 17, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@manav-a
Copy link
Contributor Author

manav-a commented Dec 17, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@manav-a manav-a deleted the add_two_more_to_torch_python_api branch December 18, 2024 05:22
@albanD albanD mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo suo approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manav-a @pytorchmergebot @suo