KEMBAR78
Migrate the rest of CUDA 12.1 jobs to 12.4 by huydhn · Pull Request #144118 · pytorch/pytorch · GitHub
Skip to content

Migrate the rest of CUDA 12.1 jobs to 12.4 #144118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Migrate the rest of CUDA 12.1 jobs to 12.4 #144118

wants to merge 2 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jan 3, 2025 •
edited
Loading

CUDA 12.4 is the default now and we don't build nightly 12.1 anymore, so it's time to move the rest of CI jobs to 12.4. I also clean up some redundant CI jobs on periodic and inductor-periodic.

@huydhn huydhn requested review from atalman and malfet January 3, 2025 00:25
@huydhn huydhn requested review from a team and jeffdaily as code owners January 3, 2025 00:25
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 3, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144118

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 3 Unrelated Failures

As of commit edf9f02 with merge base 8f3eb84 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn
huydhn commented Jan 3, 2025
View reviewed changes
.ci/docker/build.sh
CONDA_CMAKE=yes
TRITON=yes
;;
pytorch-linux-focal-cuda12.4-cudnn9-py3-gcc9)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are 3 duplicated entries of pytorch-linux-focal-cuda12.4-cudnn9-py3-gcc9 in the docker build script

@huydhn huydhn added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor-periodic labels Jan 3, 2025
atalman
atalman approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you

@huydhn
Copy link
Contributor Author

huydhn commented Jan 3, 2025

@pytorchbot drci

@huydhn
Copy link
Contributor Author

huydhn commented Jan 3, 2025

@pytorchbot merge -f 'Existing periodic failures, trunk jobs are not needed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@anumol-baby anumol-baby mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@malfet malfet Awaiting requested review from malfet

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/inductor-periodic ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huydhn @pytorchmergebot @atalman