KEMBAR78
Add magma cuda build 12.8 by tinglvv · Pull Request #145765 · pytorch/pytorch · GitHub
Skip to content

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Jan 27, 2025

@tinglvv tinglvv requested a review from a team as a code owner January 27, 2025 19:49
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145765

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9492f1e with merge base bdc2c2a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 29, 2025

Current workflow doesn't require adding new arch codes to the CMakeLists.patch it seems?

As pytorch/builder#2020 didn't apply any special support for sm_90 and existing v2.6.1 also https://github.com/icl-utk-edu/magma/blob/v2.6.1/CMakeLists.txt doesnt include sm_90. However current build is working fine for CUDA 12.6.

Just adding the sm_100 and sm_120 through CUDA_ARCH_LIST might be enough.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is green, than why not...

@malfet
Copy link
Contributor

malfet commented Jan 29, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 02:05 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 02:05 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 29, 2025 02:05 Inactive
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 29, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants