-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Add magma cuda build 12.8 #145765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add magma cuda build 12.8 #145765
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145765
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9492f1e with merge base bdc2c2a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Current workflow doesn't require adding new arch codes to the CMakeLists.patch it seems? As pytorch/builder#2020 didn't apply any special support for sm_90 and existing v2.6.1 also https://github.com/icl-utk-edu/magma/blob/v2.6.1/CMakeLists.txt doesnt include sm_90. However current build is working fine for CUDA 12.6. Just adding the sm_100 and sm_120 through CUDA_ARCH_LIST might be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI is green, than why not...
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
#145570
cc @atalman @malfet @ptrblck @nWEIdia