[DataLoader] default_collate should collate bool list to byte tensors #14669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
force-pushed
the
default_collate_bool
branch
4 times, most recently
from
9f25989 to
d42bee5
Compare
ssnl
force-pushed
the
default_collate_bool
branch
from
d42bee5 to
d3cba2e
Compare
ssnl
force-pushed
the
default_collate_bool
branch
from
d3cba2e to
d514b9a
Compare
ssnl
commented
Dec 20, 2018
| return torch.DoubleTensor(batch) | ||
| return torch.tensor(batch, dtype=torch.float64) | ||
| elif isinstance(batch[0], int_classes): | ||
| return torch.tensor(batch) |
There was a problem hiding this comment.
This makes List[int] a long tensor, and List[bool] a byte tensor.
ezyang
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Laurens van der Maaten says that this broke some internal tests. I'm asking him for some more details |
|
@soumith said that he fixed the internal errors before landing. |
|
i reran the internal tests and they passed :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15331 . Review only the last commit.
Fixes #14507.