[ONNX] Deprecation message follow up #147005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
requested review from
shubhambhokare1,
titaiwangms and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147005
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit d1f05c5 with merge base 7f62616 ( UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
titaiwangms
approved these changes
Feb 12, 2025
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / linux-focal-py3.13-clang10 / test (default, 4, 5, lf.linux.4xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #146923 to address comments.
This pull request includes updates to the
torch/onnxmodule, focusing on deprecations and documentation improvements. The most important changes involve moving version change notes within theexportfunction, updating deprecation messages, and removing example code in thedynamo_exportfunction.Documentation and Deprecation Updates:
torch/onnx/__init__.py: Moved version change notes to the correct location within theexportfunction's docstring. Updated the deprecation note for thedynamo_exportfunction to version 2.7 and removed example code from its docstring. [1] [2] [3] [4]torch/onnx/utils.py: Enhanced deprecation messages for several functions (select_model_mode_for_export,disable_apex_o2_state_dict_hook,setup_onnx_logging,unconvertible_ops) to provide clearer guidance on their removal and suggest copying logic if needed. [1] [2] [3] [4] [5]